[@azure-rest/core-client] Correctly handle allowInsecureConnection override#26413
Merged
xirzec merged 3 commits intoAzure:mainfrom Jul 6, 2023
Merged
Conversation
xirzec
added
the
Client
mpodwysocki
approved these changes
Jul 6, 2023
Collaborator
|
API change check API changes are not detected in this pull request. |
3 tasks
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure-rest/core-clientIssues associated with this PR
Azure/autorest.typescript#1916
Describe the problem that is addressed by this PR
Since we were using spread syntax on
RequestParametersif anundefinedvalue was passed this would take precedence over the client option, which was not expected.This PR switches the order of when the spread happens while still pulling the value from
RequestParameterswhen present.Are there test cases added in this PR? (If not, why?)
Yes!